[darcs-users] Re: Bug: Annotate fails for re-added files

David Roundy droundy at abridgegame.org
Sat Dec 11 19:18:26 UTC 2004


On Thu, Dec 09, 2004 at 04:15:19PM +0100, Tommy Pettersson wrote:
> On Tue, Dec 07, 2004 at 07:04:23AM -0500, David Roundy wrote:
> > I think this is fixed now.  Can you try it out, to be sure? The test cases
> > I've run tend to blur together in my head.
> 
> Is this in the stable repo?  I pulled, but couldn't find
> anything that looked like a fix.  I've sent a patch with an
> annotate test that fails.  If I unpull this patch:
> 
>   Sun Nov 28 15:06:01 CET 2004  David Roundy <droundy at abridgegame.org>
>     * really fix annotate bug this time.
> 
> the test doesn't fail.  (The test should probably be extended
> with something that also makes it fail without this patch.)
> 
> 
> I just did some more testing, and it looks like the way things
> get recorded is important.

Ok, the above patch fixed one bug, but introduced another... or rather
exposed another.  The breakP function had an interesting to track down bug
in it.  Could you check yet again with:

Sat Dec 11 14:15:17 EST 2004  David Roundy <droundy at abridgegame.org>
  * fix bug in annotate when two files or dirs were added in same patch.

(Thanks for tracking these bugs down, by the way.)
-- 
David Roundy
http://www.darcs.net




More information about the darcs-users mailing list