[darcs-users] --no-pristine-tree broken

[David Roundy]

On Sat, Sep 03, 2005 at 02:22:01PM +0200, Thomas Schwinge wrote:
> Hi!

Hello!

> #v+
> $ mkdir d
> $ cd d
> $ darcs init --no-pristine-tree
> $ echo foo > bar
> $ darcs add bar
> $ darcs record -a -m baz bar
> Recording changes in "bar":

Thanks for the nicely reproducible bug report!

I've got a couple of fixes, since there were a couple of problems.  One was
that we were creating a test directory even when there isn't a test to be
run (which is a significant efficiency concern), and the second is that
when creating a test directory if there isn't a pristine cache we get the
error you see.

> On a side-note: I don't think it's good (it might even be a safety risk!)
> that darcs operates on "generic" directories like the said /tmp/testing
> and /tmp/pristine.temp.  Isn't there a wrapper for tmpfile(3) or similar
> available in Haskell?

We do check (in the normal code) whether the directory exists before
creating it, so you would end up with "testing-0" or "testing-1".  This
could be a security risk, but if that's a concern you can address it by
setting DARCS_TMPDIR (or even better, TMPDIR) to be a non-world-readable
directory.  It's nice to be able to easily see what's going on in the
running test.
-- 
David Roundy
http://www.darcs.net