[darcs-users] New long comments behavior under w2k doesn't work with my editor

[Tommy Pettersson]

On Wed, Jul 12, 2006 at 02:46:40PM -0500, Richard A. Smith wrote:
> I reciently upgraded from 1.0.5rc1 to 1.0.8.
> 
> Today when I went to review my changes I noticed that all my recient 
> long comments were missing.
> 
> After some investigation I've found that darcs is now doing something 
> different that isn't compatible with my editor.
> 
> I use ultraedit as my primary editor on windows.
> 
> Under darcs 1.0.5rc1 if my ultraedit is alrady open and I do a darcs 
> record with a long comment I would get a new duplicate copy of ultraedit 
> with the long comment file open.  Add my text and exit and darcs saves.
> 
> Under 1.0.8 I do not get a duplicate copy of ultraedit but rather it 
> opens up in my existing editor process as a new file.  But the moment 
> the file opens darcs shows "Finished recording patch 'foo'" and I get an 
> empty long comment.
> 
> If I am not currently running a copy of uedit then 1.0.8 works like 
> 1.0.5rc1 where it waits until I exit the editor and my long comments are 
> saved.

Did you also upgrade or change any settings in ultraedit? I
can't find any obvious change in darcs between 1.0.5rc1 and
1.0.8, but a few things regarding long comments has changed, so
it can very well be a darcs thing.

When darcs invokes the editor, it just sits and wait for it to
exit, and then grabs the file to see if it was changed. It is
possible that ultraedit detects an already running instance,
remotely controls it to open the file, and then exits. If so,
the behavior you experience is the expected one. Darcs can't
communicate with every type of editor to know when the editor is
finished with the file. I however can't see what change in darcs
could have made ultraedit to behave differently in this manner.

Perhaps you can set the DARCS_EDITOR environment to include some
flags for ultraedit so it doesn't do the remote thing, or you
could write a wrapper that launch ultraedit and waits for it to
finish with the file, and use that wrapper as darcs editor.


-- 
Tommy Pettersson <ptp at lysator.liu.se>