[darcs-users] Behaviour of add, with non-existent filenames

[Iago Abal]

Perhaps it would be a good idea to add a regression test so.
Sorry, completely busy right now :P

On Wed, Jun 15, 2011 at 9:28 AM, Owen Stephens <darcs at owenstephens.co.uk>wrote:

> No, that was against 2.7.3, built around the time I sent my patch to fix
> the
> issue. I've not looked in any detail at the changes that were made since
> 2.5
> that might have caused the regression.
>
> Owen.
>
>
>
> On 15 June 2011 02:19, Iago Abal <iago.abal at gmail.com> wrote:
> >
> > Are you using the last version of Darcs?
> > $ darcs --version
> > 2.5.2 (release)
> > $ mkdir repo
> > $ cd repo/
> > repo$ darcs init
> > repo$ mkdir subdir
> > repo$ cd subdir
> > repo/subdir$ darcs add foo
> > darcs: subdir/foo: getSymbolicLinkStatus: does not exist (No such file or
> directory)
> > repo/subdir$ echo $?
> > 1
> > repo/subdir$ darcs wh
> > No changes!
> >
> > On Thu, Jun 9, 2011 at 12:35 PM, Owen Stephens <darcs at owenstephens.co.uk>
> wrote:
> >>
> >> Currently, Darcs will implicitly add the directory containing a
> to-be-added
> >> file, if it is not known by Darcs. This is desirable, but has shown up
> some
> >> strange bugs.
> >>
> >> Particularly, adding a non-existent file within a newly-added directory
> will
> >> cause Darcs to print an error message, but it will exit successfully.
> Something
> >> like:
> >>
> >> $ mkdir subdir
> >> $ cd subdir
> >> $ darcs add foo
> >> File subdir/foo does not exist!
> >> $ echo $?
> >> 0
> >> $ darcs wh
> >> adddir ./subdir
> >> $ darcs add foo
> >> File subdir/foo does not exist!
> >>
> >> darcs failed:  No files were added
> >> $ echo $?
> >> 2
> >>
> >> The second time add is called, Darcs exits with a non-zero status, since
> the
> >> directory has already been added.
> >>
> >> The current fix I have coded will only add files/directories if all the
> files
> >> specified exist (if any fail to be added, no changes will be made).
> However,
> >> this could be somewhat heavy-handed - someone might want to specify a
> long list
> >> of possibly-existing files, and tolerate the failures.
> >>
> >> I can't think of an instance of this use-case (mainly because I tend to
> add
> >> files using shell-globbing, which wouldn't cause a non-existent name to
> be
> >> specified), but I'd like to know if anyone has used something that is
> similar, where
> >> my change would break the expected behaviour.
> >>
> >> What should Darcs do in the case where non-existent files are added?
> >>
> >> Cheers,
> >> Owen.
> >>
> >> _______________________________________________
> >> darcs-users mailing list
> >> darcs-users at darcs.net
> >> http://lists.osuosl.org/mailman/listinfo/darcs-users
> >>
> >
> >
> >
> > --
> > Iago Abal Rivas
>
>


-- 
Iago Abal Rivas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20110615/00a81a46/attachment.html>